Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path of AirMapModule #526

Merged
merged 1 commit into from
Sep 2, 2016
Merged

Fix path of AirMapModule #526

merged 1 commit into from
Sep 2, 2016

Conversation

spikebrehm
Copy link

The PR that added AirMapModule (#449) was merged after the PR that
moved all the lib/src/* files to just src/* (#502). Fix it by moving
AirMapModule to src/.

cc: @rops @alvinthen

Fix path of AirMapModule
9ff97a5 
The PR that added `AirMapModule` (#449) was merged after the PR that
moved all the `lib/src/*` files to just `src/*` (#502). Fix it by moving
`AirMapModule` to `src/`.
spikebrehm
spikebrehm reviewed Sep 2, 2016
View reviewed changes
android/src/main/java/com/airbnb/android/react/maps/AirMapManager.java
@@ -1,7 +1,6 @@
package com.airbnb.android.react.maps;

import android.view.View;
import android.content.Context;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an unused import.

@spikebrehm spikebrehm mentioned this pull request Sep 2, 2016
Merged
@spikebrehm
Copy link
Author

cc: @felipecsl

@alvinthen
Copy link
Contributor

My bad there, thanks for fixing

@felipecsl
Copy link
Contributor

👍

@sergionsz sergionsz mentioned this pull request Sep 2, 2016
Closed
@spikebrehm spikebrehm merged commit 76b385b into master Sep 2, 2016
@spikebrehm spikebrehm deleted the fix-path-to-airmapmanaager branch September 2, 2016 17:03
@spikebrehm
Copy link
Author

Just published 0.8.1 that includes this change.

@spikebrehm
Copy link
Author

It turns out 0.8.1 was faulty, because my working directory had an additional example app containing the react-native node module, which got published as part of the NPM package (:facepalm:), causing a @providesModule error, so I've unpublished it and published 0.8.2. Use that instead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spikebrehm @alvinthen @felipecsl