[android] fix gradle build setup for explorer, bump to gradle 2.2.0 #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spikebrehm
suggested changes
Oct 10, 2016
| maven { | ||
| // For developing the example app, expect this library to be installed as a node module | ||
| // inside of the example app. So traverse from `./android/example/node_modules/react-native-maps/android` | ||
| // to `./android/example/node_modules/react-native/android`. | ||
| // react-native should be installed since it's a peer dependency | ||
| url "$projectDir/../../react-native/android" | ||
| url "$projectDir/../example/node_modules/react-native/android" |
There was a problem hiding this comment.
This doesn't match the paths in the comment anymore. Are the paths in the comment correct?
There was a problem hiding this comment.
@spikebrehm the comment didn't make any sense. I updated it.
There was a problem hiding this comment.
@spikebrehm I had mixed up commits in different branches. it's fixed now.
spikebrehm
approved these changes
Oct 10, 2016
| // For developing the example app, expect this library to be installed as a node module | ||
| // inside of the example app. So traverse from `./android/example/node_modules/react-native-maps/android` | ||
| // to `./android/example/node_modules/react-native/android`. | ||
| // react-native should be installed since it's a peer dependency |
There was a problem hiding this comment.
It's completely wrong, though. We don't pull from node_modules for the example app
|
Do we need to release a patch fix to 0.9 for this as well? |
|
@spikebrehm afaik it really only effects the explorer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the directories.
@spikebrehm @lelandrichardson @felipecsl