Allow legalLabelInsets to be changed and animated #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated example to include a button to animate the legal label.
While structurally identical to EdgePadding, they serve completely
different purposes. Default left empty since it's an OS default (around
{left: 10, bottom: 10})
gilbox
suggested changes
Dec 8, 2016
There was a problem hiding this comment.
awesome @scarlac ! can you please fix the lint errors?
/home/travis/build/airbnb/react-native-maps/example/examples/LegalLabel.js
error A space is required after '{' object-curly-spacing
error A space is required before '}' object-curly-spacing
gilbox
approved these changes
Dec 8, 2016
|
🏆 |
Exilz
pushed a commit
to archriss/react-native-maps
that referenced
this pull request
Dec 9, 2016
) * Allow legalLabelInsets to be changed and animated Updated example to include a button to animate the legal label. * Docs for legalLabelInsets prop While structurally identical to EdgePadding, they serve completely different purposes. Default left empty since it's an OS default (around {left: 10, bottom: 10}) * Spacing / linting
|
Published as v0.12.2 |
|
@spikebrehm and @gilbox : Thanks for the quick turn-around on these fixes. Really appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added docs for legalLabelInsets as well. Related to #840
While property is structurally identical to EdgePadding, used for region fitting, they serve completely
different purposes. So a new type is defined.
Default left empty since it's an OS default (around {left: 10, bottom: 10} in my tests)