Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix component style propTypes #9

Closed
jemgold opened this issue Apr 25, 2017 · 1 comment
Closed

Fix component style propTypes #9

jemgold opened this issue Apr 25, 2017 · 1 comment

Comments

@jemgold
Copy link
Contributor

jemgold commented Apr 25, 2017

Currently our components' propTypes are defined as

const propTypes = {
  style: PropTypes.shape({
    ...ViewStylePropTypes
  }),
}
// or
const propTypes = {
  style: PropTypes.shape({
    ...ViewStylePropTypes
  }),
}

This totally breaks how styles actually work —

  • it fails with an array of styles
  • it fails with an ID returned by StyleSheet.create

It's implemented in react-primitives here — either need to copy over the code or maybe extract it to a common package? 🤔

@hd719
Copy link

hd719 commented May 1, 2017

Hello I am new to Open source can I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants