Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Done] Hi, I am translating this guide into chinese. #102

Closed
1c7 opened this issue Aug 17, 2016 · 6 comments
Closed

[Done] Hi, I am translating this guide into chinese. #102

1c7 opened this issue Aug 17, 2016 · 6 comments

Comments

@1c7
Copy link

1c7 commented Aug 17, 2016

Repo is here:
https://github.com/1c7/ruby
not done yet, I would let you guys know once I finish it.

I was wondering if possible that, you guys put this link in README.md?

[中文版](https://github.com/1c7/ruby)

like this.

it mean [chinese version here].

thanks :D

@ljharb
Copy link
Contributor

ljharb commented Aug 17, 2016

Absolutely! When you're finished, please make a pull request adding the link, and after we review it, we'll happily merge it in!

We don't yet have a "translations" section in this guide, but it would be great if you could follow the pattern here so we have a nice framework for future translations.

@1c7
Copy link
Author

1c7 commented Aug 17, 2016

@ljharb got it. Thank you!

@1c7 1c7 changed the title Hi, I am translating this guide into chinese. [Done] Hi, I am translating this guide into chinese. Sep 24, 2016
@1c7 1c7 closed this as completed Sep 24, 2016
@ljharb ljharb reopened this Sep 24, 2016
@1c7
Copy link
Author

1c7 commented Jul 31, 2018

oh, it's reopen for way too long. I now close it.

@1c7 1c7 closed this as completed Jul 31, 2018
@ljharb
Copy link
Contributor

ljharb commented Jul 31, 2018

We still need a PR adding a translations section.

@ljharb ljharb reopened this Jul 31, 2018
@1c7
Copy link
Author

1c7 commented Aug 1, 2018

@ljharb I didn't understand what you mean.
image

translation section already there.

@ljharb
Copy link
Contributor

ljharb commented Aug 1, 2018

Ah, thanks - looks like that was covered by #103.

@ljharb ljharb closed this as completed Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants