Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to omit preview composables from showkase #158

Closed
vyshas opened this issue Jun 30, 2021 · 5 comments · Fixed by #164
Closed

How to omit preview composables from showkase #158

vyshas opened this issue Jun 30, 2021 · 5 comments · Fixed by #164
Assignees
Labels
enhancement New feature or request

Comments

@vyshas
Copy link

vyshas commented Jun 30, 2021

Excellent library so far and very useful. Is there a way to omit Preview components from not appearing in Showkase browser ?

@vinaygaba
Copy link
Collaborator

Glad to hear that you like it. I think this is a pretty valid request. I'm curious to learn more about your use case. Why do you want something to be previewed in Android Studio but want to avoid it in the Showkase browser? Just trying to learn more about how this library is being used @vyshas

@vinaygaba vinaygaba added the enhancement New feature or request label Jul 16, 2021
@vinaygaba vinaygaba self-assigned this Jul 16, 2021
@vyshas
Copy link
Author

vyshas commented Jul 23, 2021

Hi @vinaygaba ,

Showkase actually solved a big problem for our android team as it would provide out of the box solution for design catalog or UI components app built in compose from our UI components library. We have plenty of engineers working on the UI components library and AS preview is used for debugging, measuring and viewing how the components appears, however not all of them need to be there in showkase browser as we use the browser as UI components catalog app for designers, PMs, engineers, etc....

There are composable items that is part of another composable and that needs to be previewed for development but not in showkase browser.

I'm certain main developers/companies can use this to build inhouse design catalog app that showcases the in-house design components with company branding, etc and in such case they would need a choice of what needs to appear in showkase browser...

@L7ColWinters
Copy link

Hi, I wanted to chime in and say that liking what you have provided with Showkase so far. We have a bug where if we want a screen that has a vertical scroll, it will crash showkase. If we could omit those previews for the full screens then it would be easier to use Showkase. I know that ideally you would just fix the bug but since many bugs can show up over time, until those bugs get fixed it would be nice just to turn things off. Also like vyshas above it's nice to control which composables you want to show.

@vinaygaba
Copy link
Collaborator

Thank you for providing more context. I'm working on an API that would allow you to skip the composables! Will add y'all to the PR once its ready (should be soon)

@vinaygaba
Copy link
Collaborator

PR is up for supporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants