Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app_name string is overridden by Showkase #173

Closed
guk-ioki opened this issue Sep 22, 2021 · 1 comment · Fixed by #175
Closed

app_name string is overridden by Showkase #173

guk-ioki opened this issue Sep 22, 2021 · 1 comment · Fixed by #175

Comments

@guk-ioki
Copy link
Contributor

The file showkase/src/main/res/values/strings.xml contains a string with the key app_name and the value Showkase.

Through manifest merging, this ends up overwriting our app's name in the manifest file.

I don't see a case for this string to exist in Showkase at all 🤔
This was referenced Sep 22, 2021
Closed
Closed
@guk-ioki guk-ioki mentioned this issue Sep 22, 2021
Merged
@vinaygaba
Copy link
Collaborator

Thanks for submitting the PR for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vinaygaba @guk-ioki