[bugfix] bignumber comparison wrong with neg values

apache · Dec 2, 2016 · 113bbc2 · 113bbc2
1 parent 168a252
commit 113bbc2
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/superset/assets/visualizations/big_number.js b/superset/assets/visualizations/big_number.js
@@ -35,7 +35,8 @@ function bigNumberVis(slice) {
       if (json.compare_lag > 0) {
         const pos = data.length - (json.compare_lag + 1);
         if (pos >= 0) {
-          vCompare = (v / data[pos][1]) - 1;
+          const vAnchor = data[pos][1];
+          vCompare = (v - vAnchor) / Math.abs(vAnchor);
         }
       }
       const dateExt = d3.extent(data, (d) => d[0]);