adjust header nav links so they are all aligned on the base line (#1786)

apache · Dec 7, 2016 · 34d0dd9 · 34d0dd9
1 parent 401d9af
commit 34d0dd9
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 6 deletions.
diff --git a/superset/assets/stylesheets/less/cosmo/bootswatch.less b/superset/assets/stylesheets/less/cosmo/bootswatch.less
@@ -40,6 +40,10 @@
   background: transparent;
 }
 
+.navbar-nav > li > a {
+  padding-top: 18px;
+}
+
 // Buttons ====================================================================
 
 .btn-default:hover {

diff --git a/superset/templates/appbuilder/navbar.html b/superset/templates/appbuilder/navbar.html
@@ -21,11 +21,15 @@
         {% include 'appbuilder/navbar_menu.html' %}
       </ul>
       <ul class="nav navbar-nav navbar-right">
-        <li><a href="https://github.com/airbnb/superset" title="Superset's Github">
-          <i class="fa fa-github fa-lg"></i></a>
+        <li>
+          <a href="https://github.com/airbnb/superset" title="Superset's Github">
+            <i class="fa fa-github"></i> &nbsp;
+          </a>
         </li>
-        <li><a href="http://airbnb.io/superset" title="Documentation">
-          <i class="fa fa-book fa-lg"></i> </a>
+        <li>
+          <a href="http://airbnb.io/superset" title="Documentation">
+            <i class="fa fa-book"></i> &nbsp;
+          </a>
         </li>
         {% include 'appbuilder/navbar_right.html' %}
       </ul>

diff --git a/superset/templates/appbuilder/navbar_right.html b/superset/templates/appbuilder/navbar_right.html
@@ -29,8 +29,13 @@
 
 {% if not current_user.is_anonymous() %}
     <li class="dropdown">
-      <a class="dropdown-toggle" data-toggle="dropdown" title="{{g.user.get_full_name()}}" href="#">
-        <span class="fa fa-user fa-lg" title=""></span><b class="caret"></b>
+      <a
+        class="dropdown-toggle"
+        data-toggle="dropdown"
+        title="{{g.user.get_full_name()}}"
+        href="javascript:void(0)"
+      >
+        <i class="fa fa-user"></i>&nbsp;<b class="caret"></b>
       </a>
         <ul class="dropdown-menu">
             <li><a href="{{appbuilder.get_url_for_userinfo}}"><span class="fa fa-fw fa-user"></span>{{_("Profile")}}</a></li>