Fixed codeclimate issue

apache · Dec 9, 2016 · 8de0fec · 8de0fec
1 parent 9ab4e7b
commit 8de0fec
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/superset/models.py b/superset/models.py
@@ -1020,7 +1020,7 @@ def query(  # sqla
                 "Datetime column not provided as part table configuration "
                 "and is required by this type of chart"))
         for m in metrics:
-            if not m in metrics_dict:
+            if m not in metrics_dict:
                 raise Exception(_("Metric '{}' is not valid".format(m)))
         metrics_exprs = [metrics_dict.get(m).sqla_col for m in metrics]
         timeseries_limit_metric = metrics_dict.get(timeseries_limit_metric)

diff --git a/superset/views.py b/superset/views.py
@@ -2202,7 +2202,8 @@ def sqllab_viz(self):
                 if agg == 'count_distinct':
                     metrics.append(models.SqlMetric(
                         metric_name="{agg}__{column_name}".format(**locals()),
-                        expression="COUNT(DISTINCT {column_name})".format(**locals()),
+                        expression="COUNT(DISTINCT {column_name})"
+                        .format(**locals()),
                     ))
                 else:
                     metrics.append(models.SqlMetric(