-
Notifications
You must be signed in to change notification settings - Fork 13k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add a Async Select that fetches options from given endpoint
- Loading branch information
Showing
6 changed files
with
112 additions
and
105 deletions.
There are no files selected for viewing
61 changes: 0 additions & 61 deletions
61
superset/assets/javascripts/SqlLab/components/DatabaseSelect.jsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| const $ = window.$ = require('jquery'); | ||
| import React from 'react'; | ||
| import Select from 'react-select'; | ||
|
|
||
| const propTypes = { | ||
| dataEndpoint: React.PropTypes.string.isRequired, | ||
| onChange: React.PropTypes.func.isRequired, | ||
| mutator: React.PropTypes.func.isRequired, | ||
| value: React.PropTypes.number, | ||
| valueRenderer: React.PropTypes.func, | ||
| placeholder: React.PropTypes.string, | ||
| }; | ||
|
|
||
| const defaultProps = { | ||
| placeholder: 'Select ...', | ||
| value: null, | ||
| valueRenderer: () => {}, | ||
| }; | ||
|
|
||
| class AsyncSelect extends React.PureComponent { | ||
| constructor(props) { | ||
| super(props); | ||
| this.state = { | ||
| isLoading: false, | ||
| options: [], | ||
| }; | ||
| } | ||
| componentDidMount() { | ||
| this.fetchOptions(); | ||
| } | ||
| fetchOptions() { | ||
| this.setState({ isLoading: true }); | ||
| const mutator = this.props.mutator; | ||
| $.get(this.props.dataEndpoint, (data) => { | ||
| this.setState({ options: mutator ? mutator(data) : data, isLoading: false }); | ||
| }); | ||
| } | ||
| onChange(opt) { | ||
| this.props.onChange(opt); | ||
| } | ||
| render() { | ||
| return ( | ||
| <div> | ||
| <Select | ||
| placeholder={this.props.placeholder} | ||
| options={this.state.options} | ||
| value={this.props.value} | ||
| isLoading={this.state.isLoading} | ||
| onChange={this.onChange.bind(this)} | ||
| valueRenderer={this.props.valueRenderer} | ||
| /> | ||
| </div> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| AsyncSelect.propTypes = propTypes; | ||
| AsyncSelect.defaultProps = defaultProps; | ||
|
|
||
| export default AsyncSelect; |
17 changes: 9 additions & 8 deletions
17
...avascripts/sqllab/DatabaseSelect_spec.jsx → ...vascripts/components/AsyncSelect_spec.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,35 @@ | ||
| import React from 'react'; | ||
| import Select from 'react-select'; | ||
| import DatabaseSelect from '../../../javascripts/SqlLab/components/DatabaseSelect'; | ||
| import AsyncSelect from '../../../javascripts/components/AsyncSelect'; | ||
| import { shallow } from 'enzyme'; | ||
| import { describe, it } from 'mocha'; | ||
| import { expect } from 'chai'; | ||
| import sinon from 'sinon'; | ||
|
|
||
| describe('DatabaseSelect', () => { | ||
| describe('AsyncSelect', () => { | ||
| const mockedProps = { | ||
| actions: {}, | ||
| dataEndpoint: '/slicemodelview/api/read', | ||
| onChange: sinon.spy(), | ||
| mutator: () => {}, | ||
| }; | ||
| it('is valid element', () => { | ||
| expect( | ||
| React.isValidElement(<DatabaseSelect {...mockedProps} />) | ||
| React.isValidElement(<AsyncSelect {...mockedProps} />) | ||
| ).to.equal(true); | ||
| }); | ||
|
|
||
| it('has one select', () => { | ||
| const wrapper = shallow( | ||
| <DatabaseSelect {...mockedProps} /> | ||
| <AsyncSelect {...mockedProps} /> | ||
| ); | ||
| expect(wrapper.find(Select)).to.have.length(1); | ||
| }); | ||
|
|
||
| it('calls onChange on select change', () => { | ||
| const onChange = sinon.spy(); | ||
| const wrapper = shallow( | ||
| <DatabaseSelect onChange={onChange} /> | ||
| <AsyncSelect {...mockedProps} /> | ||
| ); | ||
| wrapper.find(Select).simulate('change', { value: 1 }); | ||
| expect(onChange).to.have.property('callCount', 1); | ||
| expect(mockedProps.onChange).to.have.property('callCount', 1); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters