[table viz] allow sorting on any column (#1601)

* [table viz] allow sorting on any column

* explorev2

superset/forms.py

@@ -134,7 +134,7 @@ def __init__(self, viz):
         default_groupby = gb_cols[0] if gb_cols else None
         group_by_choices = self.choicify(gb_cols)
         order_by_choices = []
-        for s in sorted(datasource.num_cols):
+        for s in sorted(datasource.column_names):
             order_by_choices.append((json.dumps([s, True]), s + ' [asc]'))
             order_by_choices.append((json.dumps([s, False]), s + ' [desc]'))
         # Pool of all the fields that can be used in Superset

superset/views.py

@@ -2142,7 +2142,7 @@ def fetch_datasource_metadata(self):
 
         gb_cols = [(col, col) for col in datasource.groupby_column_names]
         order_by_choices = []
-        for s in sorted(datasource.num_cols):
+        for s in sorted(datasource.column_names):
             order_by_choices.append((json.dumps([s, True]), s + ' [asc]'))
             order_by_choices.append((json.dumps([s, False]), s + ' [desc]'))
 

superset/viz.py

@@ -440,7 +440,7 @@ def query_obj(self):
         if fd.get('all_columns'):
             d['columns'] = fd.get('all_columns')
             d['groupby'] = []
-            order_by_cols = fd.get('order_by_cols', []) or []
+            order_by_cols = fd.get('order_by_cols') or []
             d['orderby'] = [json.loads(t) for t in order_by_cols]
         return d