Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persisting desktop refresh interval/frequency #1725

Closed
wants to merge 5 commits into from

Conversation

dineshsoft
Copy link

Currently desktops refresh interval setup by user get vanish when they refresh or log back. This change is to persist desktop refresh frequency so that can be reflected to user for that desktop

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer the approach of squeezing a new key refreshFrequency in models.Dashboard.json_metadata. That would remove the need for an extra endpoint, db migration script and dom injection.

@olbapito
Copy link

olbapito commented May 8, 2017

Hi! Do you know when will this change be commited into the master branch?
Thanks!

@mistercrunch
Copy link
Member

Given the merge conflicts and long time not addressed requested changes I'm going to close this. Please reopen with the proposed approach and a successful build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants