Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid fine print. #1759

Closed
wants to merge 2 commits into from
Closed

Avoid fine print. #1759

wants to merge 2 commits into from

Conversation

akuhn
Copy link
Contributor

@akuhn akuhn commented Dec 4, 2016

We should not use 12px font size to avoid agism in design. At age 40, eyesight is about half as good as it did at age 20. I changed all font sizes to be at least 14px.

Loving the new homepage by the way! 馃帀

Reviewers

@ascott
Copy link
Contributor

ascott commented Dec 6, 2016

i like the spirit of this PR, and would be happy to make changes to the font size, but i'd like to review these specific cases to see if there is a reason we've bumped the text size down. would be great to include screenshots of the ui that these rules affect. we may also want to get rid of these custom font-size rules and rely on the base font size that is set in bootstrap.

@ascott
Copy link
Contributor

ascott commented Dec 6, 2016

looks like our base font size is 14px, so if we could just remove these rules altogether to get to 14px.

screenshot 2016-12-05 17 36 10

@akuhn
Copy link
Contributor Author

akuhn commented Dec 8, 2016

Excited to hear!

Happy to share screenshots internally

  • font size of table on home page
  • font size of table in sqllab
  • font size of tooltips in sqllab
  • font size of optional description at top of a dashboard slice

There is more fine print that I haven't caught yet like the buttons and partition info in sqllab. You can do the following to preview how a 14pt website would look like

  • Visit settings
  • Click advanced link
  • Click customize fonts button
  • Change minimal font size slider to 14

@mistercrunch
Copy link
Member

This is been open for a while, closing for now. For me hitting Command-+ is an easy way to adapt the font size.

@mistercrunch mistercrunch deleted the avoid_tiny_font_size branch February 8, 2018 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants