Fix capitalization of "Spacefleet" in README #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starfleet is one word :-p why not Spacefleet? |
|
¯\_(ツ)_/¯ |
|
Iirc @kompfner added it. I support the change. |
|
There's a whole linguistic thing for how two words become single compound words. |
|
Seems like we need a new guiding tenet 😜 |
|
Given I'm not a native english speaker I'll leave this one to other maintainers who are to decide 😁 cc @airbnb/swift-styleguide-maintainers |
dcramps
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since space fleet is two words, the class name used in this example should have the correct casing to reflect that.
Spacefleet->SpaceFleet.Reasoning
Our examples should follow Apple's guidelines of using
UpperCamelCasefor type names.Reviewers
cc @airbnb/swift-styleguide-maintainers
Please react with 👍/👎 if you agree or disagree with this proposal.