New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(demo): upgrade to next@11 #1627
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
commented
Jan 5, 2023
@@ -66,7 +66,7 @@ | |||
"@visx/text": "2.17.0", | |||
"@visx/threshold": "2.18.0", | |||
"@visx/tooltip": "2.17.0", | |||
"@visx/visx": "2.16.0", | |||
"@visx/visx": "2.18.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was not the latest, which meant a copy of all @visx/*
packages were in a local node_modules
which would hide some errors (e.g., because they were the non-ESM versions)
williaster
commented
Jan 5, 2023
4 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃彔 Internal
Before it was reverted, #1578 broke the nextjs site due to the resulting
d3-*
ESM modules with the errorError [ERR_REQUIRE_ESM]: require() of ES Module /Users/christopher-williams/dev/visx/packages/visx-demo/node_modules/@visx/scale/node_modules/d3-scale/src/index.js from /Users/christopher-williams/dev/visx/packages/visx-demo/node_modules/@visx/scale/lib/scales/band.js not supported.
This PR
next@9.5.4
tonext@^11
and turns on its experimental support for esm modules9=>10
10=>11
because we're onreact@18
, but some SSR mismatch errors surfaced and I had to refactor some of our next-config + happo config which referencesnext
's webpack configuration.next-transpile-modules
with config for the problematicd3-*
packages@visx/visx
version invisx-demo
tsconfig
forvisx-demo
which was trying to extend a base root config which wasn't working greatverified that the site builds locally when rebased on #1578