-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specifying tick label props should not wipe all defaults #1657
Comments
Happy to review a PR for all this, thanks for suggesting it! Note that this will likely require updates in |
@williaster I've forked the repo and did some work on this, though whenever I run I this something you've seen before? I want to avoid potentially spending hours looking for a fix that is seemingly not related to my changes |
hey @Robin-Hoodie thanks for getting this started. hmm, I haven't seen that specific error before, but recently I've seen some issues with stale if that doesn't work, maybe you can just rely on the CI from your PR and not worry about it locally? (not ideal I know) |
@williaster Removing the |
Now, when setting something like
will remove all tick label props that had been set by default, which is probably not what most users want.
To make matters worse, the default props are not exported from
@visx/scale
so users end up having to look through the source code and copy-paste the default props in their own projects.Lastly, it would help if you'd be allowed to specify
tickLabelProps
as a plain object or a function, instead of just as a function.Happy to make a PR for this if this is something people can agree on
The text was updated successfully, but these errors were encountered: