You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been having a try with the Brush component and noticed that the margin does not have any effect on the Brush area or calculations. Even looking at the Brush-Demo you can see that the const brushMargin = { top: 10, bottom: 15, left: 50, right: 20 }; is not moving anytihing inside the <rect /> for the brush but instead is being used only by the <g /> element for the <ChartArea />
This is a bit problematic and forces you to wrap the charts in a <g /> in order to correctly align them rather then being able to build the scale using margin.left and innerWidth like is sometimes common with D3 patterns.
I've been having a try with the Brush component and noticed that the margin does not have any effect on the Brush area or calculations. Even looking at the Brush-Demo you can see that the
const brushMargin = { top: 10, bottom: 15, left: 50, right: 20 };
is not moving anytihing inside the<rect />
for the brush but instead is being used only by the<g />
element for the<ChartArea />
This is a bit problematic and forces you to wrap the charts in a
<g />
in order to correctly align them rather then being able to build the scale usingmargin.left
andinnerWidth
like is sometimes common with D3 patterns.To Recreate
line 189
margin={brushMargin}
margin
prop from the<Brush />
The text was updated successfully, but these errors were encountered: