Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XYChart GlyphSeries glyphs appear at zero coordinate #1715

Closed
sshsphere opened this issue Jun 21, 2023 · 2 comments · Fixed by #1730
Closed

XYChart GlyphSeries glyphs appear at zero coordinate #1715

sshsphere opened this issue Jun 21, 2023 · 2 comments · Fixed by #1730

Comments

@sshsphere
Copy link
Contributor

When using GlyphSeries the glyphs don't follow the data, instead all glyphs appear at the (0, 0) coordinate. AnimatedGlyphSeries works correctly.

I encountered this bug in my own project, but you can reproduce it in the XYChart example:

  1. go to https://airbnb.io/visx/xychart
  2. check "render glyphs"
  3. uncheck "use animated components"
  4. all glyphs appear at top left corner

I tested with the latest versions of Chrome and Firefox

@williaster
Copy link
Collaborator

thanks for the report, this is indeed broken 😳 happy to review a PR if anyone wants to take a look.

@SheaJanke
Copy link
Contributor

It seems like the issue here is with the demo implementation, not the @visx/xychart package. The demo is not using passing the top and left props to the glyph components, causing all the glyphs to be placed at (0,0). I created a potential fix for this above ⬆️.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants