Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is "labelOrientation" in annotation's LinePath.js file? #20

Closed
Flaque opened this issue May 13, 2017 · 2 comments
Closed

What is "labelOrientation" in annotation's LinePath.js file? #20

Flaque opened this issue May 13, 2017 · 2 comments

Comments

@Flaque
Copy link
Contributor

Flaque commented May 13, 2017 •
edited

LinePath.js has a parameter labelOrientation = 'horizontal' that doesn't seem to do anything. Can we remove it?

EDIT: Also "labelVerticalAlign", and "labelHorizontalAlign" are not used.
@hshoff
Copy link
Member

hshoff commented May 16, 2017

Yup, these are TODOs for me.

@Flaque
Copy link
Contributor Author

Flaque commented May 16, 2017

TODO's to remove or TODO's to do something with them? I can remove them and submit a PR if you'd like.

@Flaque Flaque closed this as completed Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hshoff @Flaque