Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importing full Lodash library #256

Closed
Zaitsev opened this issue Mar 21, 2018 · 4 comments
Closed

importing full Lodash library #256

Zaitsev opened this issue Mar 21, 2018 · 4 comments

Comments

@Zaitsev
Copy link

Zaitsev commented Mar 21, 2018

Such import caused full lodash library to be imported
import debounce from 'lodash/debounce';
doing tree-shaking etc requires special bablel and webpack configs
It is better to use lodash.debounce stand-alone library

@hshoff
Copy link
Member

hshoff commented Mar 21, 2018

Thanks @Zaitsev, that's my fault. Will get this fixed.

@hshoff
Copy link
Member

hshoff commented Mar 22, 2018

Oh wait this was intentional #66
@lencioni is vx doing this right?

@lencioni
Copy link
Contributor

I wouldn't expect import from lodash/foo to bring in all of lodash. Can you put together a minimal repro of what you are seeing?

@hshoff
Copy link
Member

hshoff commented Jun 9, 2018

This should be fixed with the new build. https://github.com/hshoff/vx/pull/298/files#diff-945ec5ee113a4a7af5962b7d29372674R46

@hshoff hshoff closed this as completed Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants