Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@visx/xychart not available from @visx/visx package #974

Closed
valtism opened this issue Dec 19, 2020 · 6 comments · Fixed by #1043
Closed

@visx/xychart not available from @visx/visx package #974

valtism opened this issue Dec 19, 2020 · 6 comments · Fixed by #1043

Comments

@valtism
Copy link
Contributor

valtism commented Dec 19, 2020

Hi guys. Super excited about xychart being out.

Just noticed that since I'm using the @visx/visx import for prototyping that importing from @visx/xychart is not supported, and I have to manually install the @visx/xychart package.

Would like to be able to pull from the umbrella package like I can for the others. Thanks!

@williaster
Copy link
Collaborator

Hey @valtism thanks for checking out xychart and reporting this 🙏 This was an oversight by me and we should definitely add it. I'm a low on bandwidth over the holidays but happy to review a PR or can likely get to it next week!

@valtism
Copy link
Contributor Author

valtism commented Dec 23, 2020

Thanks! Zero rush on this feature, just a nice-to-have :)

@ShaneHudson
Copy link

I've picked this one up in PR #984 👍

@Christian-Sesta
Copy link

Curious how this issue is progressing?

@ShaneHudson
Copy link

I closed the PR I raised as it turned out to be a trickier change and I didn't have any spare time to pick up the extra changes. Sounds like @williaster knows how to handle it though.

@williaster
Copy link
Collaborator

Sorry just saw that #984 was closed. I can do this this week, it was slightly more complicated than we expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment