Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinkHorizontalStep appears to be vertical #820

Closed
fdevillard opened this issue Sep 30, 2020 · 1 comment · Fixed by #847
Closed

LinkHorizontalStep appears to be vertical #820

fdevillard opened this issue Sep 30, 2020 · 1 comment · Fixed by #847
Labels
🐣 beginner friendly 🐛 bug 👋 help wanted

Comments

@fdevillard
Copy link

Hi there,

It looks like the LinkHorizontalStep is actually vertical. It turns out that it my project the LinkHorizontalLine is working well.

My guess is that the LinkHorizontalStep is missing a similar code from the LinkHorizontalLine:

  x = getY, // note this returns a y value
  y = getX, // note this returns a x value

Which is, in LinkHorizontalStep:

  x = getX,
  y = getY,

Cheers,
Florent
@williaster williaster mentioned this issue Oct 6, 2020
Merged
@williaster
Copy link
Collaborator

williaster commented Oct 6, 2020 •
edited

@fdevillard thanks for reporting this! have a fix out in #847.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐣 beginner friendly 🐛 bug 👋 help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(shape/LinkHorizontalStep): render horizontally not vertically airbnb/visx
3 participants
@hshoff @fdevillard @williaster