Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging and CI refactor #23

Merged
merged 9 commits into from Dec 9, 2015
Merged

packaging and CI refactor #23

merged 9 commits into from Dec 9, 2015

Conversation

stavxyz
Copy link
Contributor

@stavxyz stavxyz commented Oct 20, 2015

Among other things, this change adds a circle.yml file so we can start testing airbrake-python using CircleCI which is free for open source projects like this one.

The python versions I have configured for testing are:

  • 2.7.9
  • 2.7.10
  • 3.3.3
  • 3.4.3
  • 3.5.0

I have a passing CircleCI build on my fork against the code in this pull request: https://circleci.com/gh/samstav/airbrake-python/12

@stavxyz
Copy link
Contributor Author

stavxyz commented Oct 20, 2015

In order to use CircleCI, an owner on this repo will need to go here and allow the project to be tested: https://circleci.com/gh/airbrake/airbrake-python

@gondoi
Copy link
Contributor

gondoi commented Oct 21, 2015

👍

@gifflen
Copy link

gifflen commented Dec 7, 2015

@kyrylo Any chance you could have someone from the team review? Been waiting on a merge for this for a while. Thanks!

@kyrylo
Copy link
Contributor

kyrylo commented Dec 7, 2015

Hey! Thanks for the reminder. Never hesitate to ping, you are always welcome :)

We'll review this ASAP (which is probably tomorrow or during this week).

@stavxyz
Copy link
Contributor Author

stavxyz commented Dec 7, 2015

@kyrylo If you are cool with testing in CircleCI, an owner will need to go here and choose to "follow" the project: https://circleci.com/gh/airbrake/airbrake-python

@phumpal
Copy link
Contributor

phumpal commented Dec 8, 2015

@samstav 👍 on the tox + circleci additions. LGTM

@kyrylo LGTM.

@vmihailenco want to give this a one over when you have a moment?

@vmihailenco
Copy link
Contributor

I think I enabled CircleCI, but it fails https://circleci.com/gh/airbrake/airbrake-python/1

@kyrylo
Copy link
Contributor

kyrylo commented Dec 9, 2015

@samstav
@kyrylo If you are cool with testing in CircleCI

That's our preferred way! :)

@gifflen
Copy link

gifflen commented Dec 9, 2015

Looks like its circle trying to infer how to run tests. Will work with @samstav to try to get things going more as intended.

Thanks getting the ball rolling.

@stavxyz
Copy link
Contributor Author

stavxyz commented Dec 9, 2015

phumpal added a commit that referenced this pull request Dec 9, 2015
packaging and CI refactor
@phumpal phumpal merged commit 01bc275 into airbrake:master Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants