Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airbrake not respecting config.ignore on wrapped exceptions #370

Closed
joevandyk opened this issue Mar 7, 2015 · 4 comments · Fixed by #433
Closed

Airbrake not respecting config.ignore on wrapped exceptions #370

joevandyk opened this issue Mar 7, 2015 · 4 comments · Fixed by #433
Labels

Comments

@joevandyk
Copy link
Contributor

Rails raises ActionDispatch::ParamsParser::ParseErrorthat wraps a JSON::ParserError exception. I have config.ignore << "ActionDispatch::ParamsParser::ParseError" in my Airbrake config.

However, the exceptions are still being sent to Airbrake, it shows up as JSON::ParserError.

I don't want to ignore all JSON::ParserErrors, just this particular one while it's wrapped in the ActionDispatch one.

@kenn
Copy link

kenn commented Mar 7, 2015

Came from rails/rails#17731 and true, it's an Airbrake bug.

Also, I think it's worth considering that client errors like ActionDispatch::ParamsParser::ParseError or ActionController::ParameterMissing can be ignored by default.

@joevandyk
Copy link
Contributor Author

Yes, I think those should be added to the default list.

I have a pull request out there for fixing this bug btw.

@kenn
Copy link

kenn commented Mar 22, 2015

Any thoughts? @dvdplm @shifi @alif

@kenn
Copy link

kenn commented Mar 22, 2015

FWIW, it's a win-win because the Airbrake server will have fewer API hits, and users see less noise and have less time wasted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants