Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip dont error when invalid jsonSchemaNode is found during traversal #44

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented Aug 14, 2023

Overview

Related to https://github.com/airbytehq/oncall/issues/2703

The goal is to relax the hard requirement of the json node being an object.

Why?

The release of a new stripe catalog revealed that

  1. We had been successfully using a catalog for 2 months with a node considered invalid by this diff tool
  2. That this diff tool would fail when prevented with a valid json object, that we just didnt like

Because of this we opted to change the behaviour of this diff to simply skip the node.

This then causes the diff to treat the field as a new field when it becomes valid

Alternatives considered

1. A migration of catalogs

We could have edited all catalogs and configured catalogs in the last two months for stripe but that was deemed to risky and didnt solve the root issue

2. Traverse the array instead of skip

We could make this so the diff treats the change from invalid type to valid as an update. But that makes less sense

@bnchrch bnchrch marked this pull request as ready for review August 14, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants