Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SnowflakeConnectionSupplier #10337

Closed
tuliren opened this issue Feb 15, 2022 · 0 comments · Fixed by #10342
Closed

Refactor SnowflakeConnectionSupplier #10337

tuliren opened this issue Feb 15, 2022 · 0 comments · Fixed by #10342
Assignees
@tuliren
Labels
area/connectors Connector related issues connectors/destination/snowflake type/bug Something isn't working
Milestone
ConnCore Feb 16, ...

Comments

@tuliren
Copy link
Contributor

tuliren commented Feb 15, 2022

When calling getConnection from this class, it is actually creating a new data source each time. It should reuse an existing data source and just create a connection instead.

https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/destination-snowflake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeDatabase.java#L79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tuliren tuliren

Labels
area/connectors Connector related issues connectors/destination/snowflake type/bug Something isn't working
Projects
None yet
Milestone
ConnCore Feb 16, 2021
Development

Successfully merging a pull request may close this issue.

🐞 Snowflake destination: use pooled connections airbytehq/airbyte
1 participant
@tuliren