Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Bing Ads: redirect_url is not needed #12488

Closed
Tracked by #12238
sherifnada opened this issue Apr 30, 2022 · 0 comments · Fixed by #12937
Closed
Tracked by #12238

Source Bing Ads: redirect_url is not needed #12488

sherifnada opened this issue Apr 30, 2022 · 0 comments · Fixed by #12937

Comments

@sherifnada
Copy link
Contributor

Current Behavior

The redirect_url parameter requested by the connector is not needed. You'll notice that the connector only uses the method request_oauth_tokens_by_refresh_tokens which does not require the use of redirect_url. Therefore it's not required for the parameter to be included in spec.json and should be removed.

Expected Behavior

remove the parameter from spec.json in a backwards compatible way (keeping additionalProperties=true so as not to break the config for existing users)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2 participants