Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle UnknownHostException as a config #17756

Closed
ryankfu opened this issue Oct 7, 2022 · 2 comments
Closed

Gracefully handle UnknownHostException as a config #17756

ryankfu opened this issue Oct 7, 2022 · 2 comments
Assignees

Comments

@ryankfu
Copy link
Contributor

ryankfu commented Oct 7, 2022

Tell us about the problem you're trying to solve

Add validation check for UnknownHostException within check stage. Currently, there's error handling that is caught within the discover phase and that later in the lifecycle for Airbyte. Preferably Airbyte catches this earlier. This follows after the conversation from here

Describe the solution you’d like

Add a validation check for pinging host within the check stage of Airbyte lifecycle

Describe the alternative you’ve considered or used

Additional context

N/A

Are you willing to submit a PR?

Remove this with your answer :-)

@bleonard
Copy link
Contributor

Investigate if this is error in their setup. If so and we can reliably catch it, then:

  1. return instructions for user
  2. stack trace as a config_error
  3. See if there is something to add to check - it has to be fast.

@bleonard bleonard changed the title Add validation check for UnknownHostException within check stage Gracefully handle UnknownHostException Oct 19, 2022
@bleonard bleonard changed the title Gracefully handle UnknownHostException Gracefully handle UnknownHostException as a config Oct 19, 2022
@akashkulk
Copy link
Contributor

This is actually handled as a ConnectionErrorException
Which is handled at the top-level as a config-error. I think this can be closed - there is no action to take here. This would not create a Sentry crash. In addition, the workspace in question was Liren's test workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants