Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle invalid Connector Builder yaml well #18918

Closed
lmossman opened this issue Nov 3, 2022 · 0 comments · Fixed by #19001
Closed

Handle invalid Connector Builder yaml well #18918

lmossman opened this issue Nov 3, 2022 · 0 comments · Fixed by #19001
Assignees
@lmossman
Labels
team/extensibility

Comments

@lmossman
Copy link
Contributor

lmossman commented Nov 3, 2022 •
edited
Loading

Context

There are several things in the behavior of the P0 connector builder that are not obvious when the user makes a change to the yaml that causes it to be invalid, which this issue is focusing on fixing.

Acceptance Criteria

  • Disable the download yaml and test buttons while the yaml is invalid
  • Refactor the state so that it is stored in the yaml editor component, and only the json is in the shared state service
  • (stretch) Add yaml validation, similar to this CodeSandbox: https://codesandbox.io/s/lnh9t?file=/src/App.tsx
@lmossman lmossman changed the title Handle invalid yaml well Handle invalid Connector Builder yaml well Nov 3, 2022
@lmossman lmossman mentioned this issue Nov 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmossman lmossman

Labels
team/extensibility
Projects
None yet
Milestone
No milestone
1 participant
@lmossman