Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting of rows in syncCatalog table #19092

Closed
teallarson opened this issue Nov 7, 2022 · 2 comments · Fixed by #19449
Closed

Highlighting of rows in syncCatalog table #19092

teallarson opened this issue Nov 7, 2022 · 2 comments · Fixed by #19449
Assignees
Labels
area/frontend Related to the Airbyte webapp team/platform-move

Comments

@teallarson
Copy link
Contributor

teallarson commented Nov 7, 2022

https://www.figma.com/file/liLQhcbpVHiEDW18kiXQe3/01_03_CONNECTIONS?node-id=2289%3A50694

This handles all possible states:

  • New row after refresh
  • Removed row after refresh (? would this even be there?)
  • Changed row after refresh (or after bulk edit!)
  • Disabled row
  • Enabled row
  • Bulk edit selected row (will look the same as a "changed" row

Some notes after syncing with Nico:

  • the "plus" should appear for rows enabled during bulk edit, the change icon for rows that had a PK/cursor change, a minus for rows that were disabled
  • a stream being added trumps a stream being changed (so if a stream is enabled and then the primary key is changed, it should be coded as a "new row" not a "changed row")
@octavia-squidington-iv
Copy link

cc @airbytehq/frontend

@teallarson
Copy link
Contributor Author

Chatted with @edmundito and this issue outranks the others currently at the top of the backlog. It's a direct split out from the design pass so doesn't require separate grooming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp team/platform-move
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants