Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Amazon Ads: attribution reports should be emitted as individual documents #19216

Closed
mdibaiee opened this issue Nov 9, 2022 · 2 comments

Comments

@mdibaiee
Copy link
Contributor

mdibaiee commented Nov 9, 2022

Environment

  • Airbyte version: N/A
  • OS Version / Instance: N/A
  • Deployment: N/A
  • Source Connector and version: Source Amazon Ads 0.1.25
  • Destination Connector and version: N/A
  • Step where error happened: Sync job

Current Behavior

  • Amazon's attribution reports (🎉 Source Amazon Ads : Add attribution reports #16342) are currently emitted as an array along with their cursor, this leads to each emitted "document" from the connector being in fact a batch of documents. To materialize an attribution report, instead of getting each report document materialized as one document, you get one document with an array of reports. Moreover this means the attribution reports can't have a primary key.

Expected Behavior

I would expect that the attribution report streams return each individual response from the API as an individual document, with the proper primary key (e.g. [campaign_id, adGroupId]). The cursor field and the array are information I expect the connector to use to handle proper pagination and emit reports. In a sense, the results from the API should be flattened by the connector to end up with a stream of report documents.

Logs

Steps to Reproduce

N/A

Are you willing to submit a PR?

Maybe.

@octavia-squidington-iii
Copy link
Collaborator

At Airbyte, we seek to be clear about the project priorities and roadmap. This issue has not had any activity for 180 days, suggesting that it's not as critical as others. It's possible it has already been fixed. It is being marked as stale and will be closed in 20 days if there is no activity. To keep it open, please comment to let us know why it is important to you and if it is still reproducible on recent versions of Airbyte.

@octavia-squidington-iii
Copy link
Collaborator

This issue was closed because it has been inactive for 20 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants