Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAT] [JAVA] Add DISCOVER, CHECK, and READ SAT tests for Java sources with local instances #19258

Closed
evantahler opened this issue Nov 9, 2022 · 6 comments
Assignees
Labels
Epic from/connector-ops SAT-on-database-source team/db-dw-sources Backlog for Database and Data Warehouse Sources team

Comments

@evantahler
Copy link
Contributor

evantahler commented Nov 9, 2022

From Add SAT to all Source Connectors - Tech Spec

This will involve determining how to boot up test source docker containers. To complete the initial story, we should get CHECK and READ testing working for one Java source (source-postgres), and then create and assign additional stories to the Java Sources team to complete.

@evantahler
Copy link
Contributor Author

@DoNotPanicUA You mentioned that you had a prototype branch for this work perhaps?

@evantahler evantahler changed the title Add CHECK and READ SAT tests to Java Connectors Add DISCOVER, CHECK, and READ SAT tests to Java Connectors Nov 9, 2022
@evantahler evantahler changed the title Add DISCOVER, CHECK, and READ SAT tests to Java Connectors Add DISCOVER, CHECK, and READ SAT tests to one Java Connector (source-postgres) Nov 9, 2022
@DoNotPanicUA
Copy link
Contributor

@DoNotPanicUA You mentioned that you had a prototype branch for this work perhaps?

@evantahler
There are two types of sources: local, global
Local sources like Postgres require local instances for test running. That is why we have steps 2 and 3 in the tech spec execution plan.
I implemented a few POC for step 3, and my conclusion is that it might not the best idea to settle local env as part of the source. We will increase the complexity of the container handling and get a lot of work maintaining integration with the Python code, with is also required. Also, a problem is how to shut it down properly.
So, I propose to make it simple - keep small source instances in the AWS (actually, we already have) for all local sources and use them in the same way as we test global sources.

Local Source:

  • clickhouse
  • cockroachdb
  • db2
  • mssql
  • mysql
  • oracle
  • postgres
  • tidb
  • elasticsearch
  • kafka
  • sftp

Global sources:

  • bigquery
  • snowflake
  • mongodb-v2
  • redshift

Here is what I propose to do next:

  1. Add DESCOVER, CHECK and READ SAT tests to the global sources as they already have test instances.
  2. Create test instances for the local sources in the AWS.
  3. Add the tests to the local source using the AWS creds

@evantahler
Copy link
Contributor Author

In the spirit of "Done is better than Perfect", I agree that if we can skip the need for setting up and tearing down test databases, than that's probably better! Since these are read-only tests, it should be OK to run them regularly and in parallel. We also already have the required tooling for setting up secrets with SAT, so 👍!

keep small source instances in the AWS (actually, we already have)
Does every local source already have a hosted test database/server? Are any missing?

@pedroslopez
Copy link
Contributor

pedroslopez commented Nov 29, 2022

Turned this issue into an EPIC to track doing this work for the local sources. The global sources are tracked in the epic #19708

The postgres-specific implenentationo that this was pointed for has been moved into a new issue #19899

@pedroslopez pedroslopez changed the title Add DISCOVER, CHECK, and READ SAT tests to one Java Connector (source-postgres) [SAT] [JAVA] Add DISCOVER, CHECK, and READ SAT tests for Java sources with local instances Nov 29, 2022
@alafanechere
Copy link
Contributor

alafanechere commented Dec 19, 2022

@evantahler I created the issues for other java sources. I tagged the DB/DW connectors team.

Edit:
https://github.com/airbytehq/airbyte/projects/24#card-87305727
and the SAT-on-database-source label

@alafanechere
Copy link
Contributor

source-postgres is passing SAT in high strictness level mode on this PR #20549

@evantahler evantahler changed the title [SAT] [JAVA] Add DISCOVER, CHECK, and READ SAT tests for Java sources with local instances [SAT] [JAVA] Add DISCOVER, CHECK, and READ SAT tests for Java sources with local instances - First Connector Dec 19, 2022
@evantahler evantahler changed the title [SAT] [JAVA] Add DISCOVER, CHECK, and READ SAT tests for Java sources with local instances - First Connector [SAT] [JAVA] Add DISCOVER, CHECK, and READ SAT tests for Java sources with local instances Dec 19, 2022
@evantahler evantahler added the team/db-dw-sources Backlog for Database and Data Warehouse Sources team label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic from/connector-ops SAT-on-database-source team/db-dw-sources Backlog for Database and Data Warehouse Sources team
Projects
None yet
Development

No branches or pull requests

4 participants