Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix appstore connector key handling #2015

Closed
jrhizor opened this issue Feb 9, 2021 · 6 comments · Fixed by #2328, #2396 or #3201
Closed

fix appstore connector key handling #2015

jrhizor opened this issue Feb 9, 2021 · 6 comments · Fixed by #2328, #2396 or #3201
Assignees
Labels
priority/high High priority type/bug Something isn't working type/enhancement New feature or request

Comments

@jrhizor
Copy link
Contributor

jrhizor commented Feb 9, 2021

Tell us about the problem you're trying to solve

Currently the appstore connector fails because when pasting a file into the private_key field removes the newlines, and the underlying library requires the newlines to handle the file.

Describe the solution you’d like

  1. Allow configuring multiline text inputs in specs, example:
      "private_key": {
        "type": "string",
        "description": "Private_key is the contents of the <a href=\"https://developer.apple.com/documentation/appstoreconnectapi/creating_api_keys_for_app_store_connect_api\">key file</a> you use to connect to appstore's API.",
        "airbyte_secret": true,
        "multiline": true
      },
  1. Support textarea inputs in the UI for multiline that propagate the newline characters in the UI.
  2. Bump the version of the appstore connector so the resulting tap_config.json files look like:
{
  "key_id": "aa",
  "private_key": "-----BEGIN PRIVATE KEY-----\nsomething\nsomething\n-----END PRIVATE KEY-----",
  "issuer_id": "aa",
  "vendor": "0",
  "start_date": "2020-11-16T00:00:00Z"
}

Describe the alternative you’ve considered or used

I considered re-adding the newlines in files, but this seems buggy and doesn't address the general concern.

@jrhizor jrhizor added type/bug Something isn't working type/enhancement New feature or request area/frontend labels Feb 9, 2021
@jrhizor jrhizor changed the title fix appstore connector fix appstore connector key handling Feb 9, 2021
@jrhizor jrhizor added the priority/high High priority label Feb 11, 2021
@jrhizor
Copy link
Contributor Author

jrhizor commented Feb 11, 2021

File upload support might be equally good as text areas for this.

@jamakase
Copy link
Contributor

jamakase commented Mar 5, 2021

Just noticed @jrhizor @cgardens we have here secret + multine, how are we going to handle such case? In case of multiline + secret - should we make it visible when you specify it and masked with * when you edit? What's the expected behaviour?

@cgardens
Copy link
Contributor

cgardens commented Mar 5, 2021

good question.

should we make it visible when you specify it and masked with * when you edit

i think your suggestion is good.

@jamakase jamakase reopened this Mar 8, 2021
@sherifnada
Copy link
Contributor

sherifnada commented Mar 8, 2021

@cgardens are we ready to change the type of the input in the appstore source to multiline?

@cgardens
Copy link
Contributor

cgardens commented Mar 9, 2021

@sherifnada it's on master but not on an officially released version. so your call on how you want to roll it out. thinking about it now this isn't going to be backwards compatible 😭

@sherifnada
Copy link
Contributor

This issue was closed by accident. We should upgrade the appstore connector to use this by adding multiline: true to the key spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/high High priority type/bug Something isn't working type/enhancement New feature or request
Projects
None yet
4 participants