-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix appstore connector key handling #2015
Comments
File upload support might be equally good as text areas for this. |
good question.
i think your suggestion is good. |
@cgardens are we ready to change the type of the input in the appstore source to multiline? |
@sherifnada it's on master but not on an officially released version. so your call on how you want to roll it out. thinking about it now this isn't going to be backwards compatible 😭 |
This issue was closed by accident. We should upgrade the appstore connector to use this by adding |
Tell us about the problem you're trying to solve
Currently the appstore connector fails because when pasting a file into the
private_key
field removes the newlines, and the underlying library requires the newlines to handle the file.Describe the solution you’d like
textarea
inputs in the UI formultiline
that propagate the newline characters in the UI.tap_config.json
files look like:Describe the alternative you’ve considered or used
I considered re-adding the newlines in files, but this seems buggy and doesn't address the general concern.
The text was updated successfully, but these errors were encountered: