Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease Logging #203

Closed
cgardens opened this issue Sep 10, 2020 · 1 comment
Closed

Decrease Logging #203

cgardens opened this issue Sep 10, 2020 · 1 comment
Assignees
Labels
type/enhancement New feature or request

Comments

@cgardens
Copy link
Contributor

cgardens commented Sep 10, 2020

Expected Behavior

  • We are okay logging a lot, especially at the beginning, but they should be useful and human readable. Right now we are logging a lot of useless stuff which is making the useful stuff hard to consume.

Current Behavior

  • JsonReferenceProcessor logs a ton useless stuff. we should filter it.
dataline-scheduler | 2020-09-10 00:49:15 TRACE JsonReferenceProcessor:191 - key=type
dataline-scheduler | 2020-09-10 00:49:15 TRACE JsonReferenceProcessor:145 - processed: []
  • this log line happens every second.
dataline-scheduler | 2020-09-10 00:51:46 INFO  JobSubmitter:54 - Running job-submitter...
  • Type Validator prints all the time (even when nothing is invalid)
dataline-scheduler | 2020-09-10 00:52:23 DEBUG TypeValidator:136 - validate( {"connectionId":"60413b71-0fdb-4b7a-959f-7f316e2adfb0","manual":true}, {"connectionId":"60413b71-0fdb-4b7a-959f-7f316e2adfb0","manual":true}, $)
dataline-scheduler | 2020-09-10 00:52:23 DEBUG RequiredValidator:136 - validate( {"connectionId":"60413b71-0fdb-4b7a-959f-7f316e2adfb0","manual":true}, {"connectionId":"60413b71-0fdb-4b7a-959f-7f316e2adfb0","manual":true}, $)
dataline-scheduler | 2020-09-10 00:52:23 DEBUG AdditionalPropertiesValidator:136 - validate( {"connectionId":"60413b71-0fdb-4b7a-959f-7f316e2adfb0","manual":true}, {"connectionId":"60413b71-0fdb-4b7a-959f-7f316e2adfb0","manual":true}, $)
dataline-scheduler | 2020-09-10 00:52:23 DEBUG PropertiesValidator:136 - validate( {"connectionId":"60413b71-0fdb-4b7a-959f-7f316e2adfb0","manual":true}, {"connectionId":"60413b71-0fdb-4b7a-959f-7f316e2adfb0","manual":true}, $)
dataline-scheduler | 2020-09-10 00:52:23 DEBUG RequiredValidator:136 - validate( {"connectionId":"60413b71-0fdb-4b7a-959f-7f316e2adfb0","manual":true}, {"connectionId":"60413b71-0fdb-4b7a-959f-7f316e2adfb0","manual":true}, $)
dataline-scheduler | 2020-09-10 00:52:23 DEBUG TypeValidator:136 - validate( "60413b71-0fdb-4b7a-959f-7f316e2adfb0", {"connectionId":"60413b71-0fdb-4b7a-959f-7f316e2adfb0","manual":true}, $.connectionId)
dataline-scheduler | 2020-09-10 00:52:23 DEBUG UUIDValidator:136 - validate( "60413b71-0fdb-4b7a-959f-7f316e2adfb0", {"connectionId":"60413b71-0fdb-4b7a-959f-7f316e2adfb0","manual":true}, $.connectionId)
@cgardens cgardens added the type/enhancement New feature or request label Sep 10, 2020
@cgardens cgardens self-assigned this Sep 14, 2020
@cgardens
Copy link
Contributor Author

closed by #210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant