Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Postgres: non-string data types sent to destination as strings #21986

Closed
adam-bloom opened this issue Jan 27, 2023 · 4 comments
Closed
Assignees
Labels
community connectors/source/postgres team/db-dw-sources Backlog for Database and Data Warehouse Sources team type/bug Something isn't working

Comments

@adam-bloom
Copy link
Contributor

Environment

  • Airbyte version: 0.40.28 (but this has existed for at least 6+ months)
  • OS Version / Instance: AWS EC2
  • Deployment: k8s EKS
  • Source Connector and version: Postgres 1.0.38
  • Destination Connector and version: Redshift 0.3.53
  • Step where error happened: Sync job

Current Behavior

Potentially related to #21695.

All numeric data types in postgres are sent to the destinations as strings. We're using raw loading, no normalization. It doesn't make much sense that normalization would need to convert strings back to numeric types, since numeric types can be loaded directly in the destinations.

Expected Behavior

I expect the _airbyte_data object to hold numeric values for columns that are numeric in the source.

Logs

Steps to Reproduce

Are you willing to submit a PR?

Maybe

@adam-bloom adam-bloom added needs-triage type/bug Something isn't working labels Jan 27, 2023
@VitaliiMaltsev VitaliiMaltsev added the team/db-dw-sources Backlog for Database and Data Warehouse Sources team label Jan 27, 2023
@natalyjazzviolin natalyjazzviolin changed the title Postgres: non-string data types sent to destination as strings Source Postgres: non-string data types sent to destination as strings Jan 27, 2023
@natalyjazzviolin
Copy link
Contributor

@adam-bloom I'm double checking, but I believe this is expected behavior without normalization?

@adam-bloom
Copy link
Contributor Author

@natalyjazzviolin why would this be expected? With raw loading, there’s no reason every value in the loaded object would be a string - numerical and Boolean values can be serialized as json without issue.

@VitaliiMaltsev
Copy link
Contributor

@adam-bloom tested today postgres-source 1.0.42 with bigint, bigserial, boolean, float, int, numeric, decimal, real, smallint, smallserial, serial datatypes and cannot reproduce an issue from description. All values loaded to the proper JsonNodes in _airbyte_data(int to IntNode, float to DoulbleNode, null to NullNode, bool to BooleanNode, etc)
json-nodes-values

Do you have any more additional tips how to reproduce it?

@adam-bloom
Copy link
Contributor Author

@VitaliiMaltsev thanks for confirming. I took another look again today - this appears to be something internal to redshift SUPER handling and not an airbyte issue. Sorry for the false report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community connectors/source/postgres team/db-dw-sources Backlog for Database and Data Warehouse Sources team type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants