Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB Sources MySQL: Handle when a cursor value is NULL #23632

Closed
prateekmukhedkar opened this issue Mar 1, 2023 · 1 comment · Fixed by #23908
Closed

DB Sources MySQL: Handle when a cursor value is NULL #23632

prateekmukhedkar opened this issue Mar 1, 2023 · 1 comment · Fixed by #23908
Assignees
@VitaliiMaltsev
Labels
autoteam connectors/source/mssql connectors/source/mysql needs-triage team/db-dw-sources Backlog for Database and Data Warehouse Sources team type/enhancement New feature or request

Comments

@prateekmukhedkar
Copy link
Contributor

We added the ability for Postgres to handle NULL cursor values; this ticket is written as a feature port for MySQL database source. The outcome of this ticket is similar behavior to Postgres #19889.
@octavia-squidington-iii octavia-squidington-iii added autoteam team/db-dw-sources Backlog for Database and Data Warehouse Sources team labels Mar 1, 2023
@bleonard
Copy link
Contributor

bleonard commented Mar 1, 2023

Have to think more about the rollout this time.
Go over existing MySQL workspaces and figure out who is affected.
Add a log that notes this case and then check in datadog to understand the customers impacted. Work with support to rectify the sources.

  1. Write SQL for MySQL and MSSQL (can be different PRs)
  2. Log when there is a predicted issue MySQL and MSSQL and deploy that.
  3. Opt in to throwing the throw error when there is NULL.

@VitaliiMaltsev VitaliiMaltsev linked a pull request Mar 9, 2023 that will close this issue
MySQL/MsSQL Source: stop sync on null cursor value #23908
Merged
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VitaliiMaltsev VitaliiMaltsev

Labels
autoteam connectors/source/mssql connectors/source/mysql needs-triage team/db-dw-sources Backlog for Database and Data Warehouse Sources team type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MySQL/MsSQL Source: stop sync on null cursor value airbytehq/airbyte
4 participants
@bleonard @VitaliiMaltsev @octavia-squidington-iii @prateekmukhedkar