Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Redshift VARCHAR to SUPER migration code #25519

Closed
cynthiaxyin opened this issue Apr 25, 2023 · 1 comment · Fixed by #25698 or #25771
Closed

Remove Redshift VARCHAR to SUPER migration code #25519

cynthiaxyin opened this issue Apr 25, 2023 · 1 comment · Fixed by #25698 or #25771
Assignees
@cynthiaxyin
Labels
team/destinations Destinations team's backlog

Comments

@cynthiaxyin
Copy link
Contributor

cynthiaxyin commented Apr 25, 2023 •
edited

See #25517 which addresses an associated integration test.
@cynthiaxyin cynthiaxyin added the team/destinations Destinations team's backlog label Apr 25, 2023
@cynthiaxyin cynthiaxyin mentioned this issue Apr 25, 2023
Merged
@evantahler
Copy link
Contributor

evantahler commented Apr 25, 2023 •
edited

Grooming:

History

  • Redshift used to use VARCHAR and then we moved to SUPER type for RAW DATA. This was 1 year+ ago. Code still in the connector (normalization).

Notes:

  • Shouldn't be any merge conflicts with work to move normalization into connector
  • The team voted 100% to remove this migration code.

Links:

Implementation

  1. Ryan and Cynthia to sync on the history of the failure
  2. Skip/disable/comment-out the broken test to unblock everyone else - use @ignore (that's destination-redshift is failing nightly connector health checks #25325)
  3. Test destination-redshift and base-normalization
  4. Remove the test and the implementation in the same PR

@evantahler evantahler mentioned this issue Apr 25, 2023
Closed
@cynthiaxyin cynthiaxyin mentioned this issue May 1, 2023
Merged
@volta-net volta-net bot closed this as completed May 2, 2023
@cynthiaxyin cynthiaxyin reopened this May 2, 2023
@volta-net volta-net bot closed this as completed May 2, 2023
@cynthiaxyin cynthiaxyin mentioned this issue May 2, 2023
Merged
@cynthiaxyin cynthiaxyin changed the title Remove Redshift migration code for tmp tables Remove Redshift VARCHAR to SUPER migration code May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cynthiaxyin cynthiaxyin

Labels
team/destinations Destinations team's backlog
Projects
None yet
Milestone
No milestone
2 participants
@evantahler @cynthiaxyin