Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup connected account tests for Airbyte-native stripe connector #3122

Closed
sherifnada opened this issue Apr 28, 2021 · 5 comments · Fixed by #3367
Closed

Setup connected account tests for Airbyte-native stripe connector #3122

sherifnada opened this issue Apr 28, 2021 · 5 comments · Fixed by #3367

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Apr 28, 2021

Tell us about the problem you're trying to solve

#3121 added support for reading data from stripe connected accounts.

However, we don't have adequate test coverage for testing data from Stripe Connected Accounts. To have that we'll need to do the following:

  1. Use the lastpass creds "Stripe Connected Account Test Creds" (put them in secrets/connected_account_config.json)
  2. Use the credentials to populate the connected account with data for all possible streams (see all streams in schemas/ folder)
  3. Migrate source-stripe to start using the new Source Acceptance tests (reach out to Eugene K so he can point you to the docs and examples)
  4. In the Source Acceptance Tests, run the test configs using both configs (config.json and connected_account_config.json)
  5. Add the credentials to github CI and ci_credentials.sh, test_command.yml and publish_command.yml
  6. Add the connector to source_definitions.yml and remove the singer connector
  7. Modify the connector health page to point to the new build page
  8. If any code changes are required, publish a new version of the connector
  9. Modify the connector documentation (airbyte/docs/integrations/sources/stripe.md) to mention the additional streams it syncs (bank_accounts and refunds)
@sherifnada sherifnada added type/enhancement New feature or request area/connectors Connector related issues labels Apr 28, 2021
@sherifnada sherifnada added this to the Connectors May 14th 2021 milestone Apr 28, 2021
@Zirochkaa
Copy link
Contributor

@sherifnada I have a question about item number 5 from issue description (Add the credentials to github CI and ci_credentials.sh, test_command.yml and publish_command.yml):

I found ci_credentials.sh file - it's located in tools/bin/ folder. But I didn't find test_command.yml and publish_command.yml files (I was using a search in PyCharm and VSCode).
Could you please wrote in which folders these files can be found?

@Zirochkaa
Copy link
Contributor

Zirochkaa commented May 3, 2021

Also there are no Stripe Connected Account Test Creds creds in LastPass (at least I don't see them).

image

image

@sherifnada
Copy link
Contributor Author

@Zirochkaa my mistake -- will update lastpass

@Zirochkaa
Copy link
Contributor

@sherifnada I have a question about item number 5 from issue description (Add the credentials to github CI and ci_credentials.sh, test_command.yml and publish_command.yml):

I found ci_credentials.sh file - it's located in tools/bin/ folder. But I didn't find test_command.yml and publish_command.yml files (I was using a search in PyCharm and VSCode).
Could you please wrote in which folders these files can be found?

Those "missing" files are in workflows folder.

@sherifnada
Copy link
Contributor Author

@Zirochkaa added connected account credentials to lastpass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants