Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal v1.20 .1 prints cleartext database password in logs #33432

Closed
adrawbond-alto opened this issue Dec 13, 2023 · 2 comments
Closed

Temporal v1.20 .1 prints cleartext database password in logs #33432

adrawbond-alto opened this issue Dec 13, 2023 · 2 comments
Labels

Comments

@adrawbond-alto
Copy link

Helm Chart Version

0.50.2

What step the error happened?

Other

Revelant information

The Airbyte Helm chart is using temporalio/auto-setup v1.20.1, which prints the Airbyte database password in cleartext in the logs. This was a known bug with Temporal, which they fixed in temporalio/docker-builds#147. Upgrading temporalio/auto-setup to v1.22.2.0 fixes the problem.

How to reproduce

Deploy Airbyte using the Helm chart to a Kubernetes cluster. Download the logs for the temporal pod using kubectl logs. You will observe near the top of the logs your database password in cleartext. Then, override the Helm chart value temporal.image.tag with 1.22.2.0 and redeploy the Helm chart. Check the temporal logs again, and the database password will no longer be present. You can further verify by exec'ing into the running temporal pods (first the v1.20.1 pod, then the v1.22.2.0 pod) and cat'ing out auto-setup.sh and observing the removal of the -x shell option in the script.

Relevant log output

No response

@marcosmarxm
Copy link
Member

Airbyte uses v1.22.3 now https://github.com/airbytehq/airbyte-platform/blob/main/airbyte-temporal/Dockerfile
Thanks for reporting the issue @adrawbond-alto

@adrawbond-alto
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants