Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New source: airbyte-native Github connector #3695

Closed
sherifnada opened this issue May 28, 2021 · 3 comments · Fixed by #4174
Closed

New source: airbyte-native Github connector #3695

sherifnada opened this issue May 28, 2021 · 3 comments · Fixed by #4174

Comments

@sherifnada
Copy link
Contributor

sherifnada commented May 28, 2021

Tell us about the new connector you’d like to have

As part of the migration away from Singer based connectors in #3582 we want to rewrite this connector using the Airbyte CDK. The new connector should have complete feature parity with the existing singer-based one. Once this is complete we should delete the singer-based connector and replace it with the new one.

┆Issue is synchronized with this Asana task by Unito

@sherifnada sherifnada added area/connectors Connector related issues new-connector labels May 28, 2021
@sherifnada sherifnada added this to the Connectors June 11, 2021 milestone May 28, 2021
@Zirochkaa Zirochkaa self-assigned this May 28, 2021
@Zirochkaa Zirochkaa added zazmic CDK Connector Development Kit labels Jun 1, 2021
@sherifnada sherifnada removed the CDK Connector Development Kit label Jun 8, 2021
@Zirochkaa
Copy link
Contributor

Zirochkaa commented Jun 10, 2021

Are the account test credentials available in Lastpass?
yes

Task breakdown

  • Create source scaffolding and populate schemas folder (3h)
  • Implement spec, check, and discover (4h)
  • Implement read command for all (16) streams in full_refresh mode (8h)
  • Add pagination (4h)
  • Compare schemas from source-github-singer and actual responses and update schemas if needed (8h)
  • Remove excessive fields from endpoints responses and check each stream (6h)
  • Configure acceptance tests for full_refresh streams (2h)
  • Add and test caching for pull_request stream (2h)
  • Add handling for error with teams stream for private repositories (2h)
  • Define which streams could be incremental (4h)
  • Update schemas for incremental streams (2h)
  • Add support for start-date parameter in spec file (8h)
  • Implement read command for incremental streams (16h)
  • Create new docs and include information about start-date parameter and about incremental streams (how they work) (4h)
  • Configure acceptance tests for incremental streams (6h)

@Moofasax
Copy link

Moofasax commented Jul 1, 2021

looking forward to trying this out!! will there be a new release created today?

@Zirochkaa
Copy link
Contributor

looking forward to trying this out!! will there be a new release created today?

@Moofasax

Sorry for such a late reply.

We just merged this connector into master and released a new version of the connector.

The connector will be available in the next release of Airbyte (we usually release every Tuesday). If you can't wait and want to get started now trying it out in a running Airbyte instance, add the connector like described in https://docs.airbyte.io/integrations/custom-connectors#adding-your-connectors-in-the-ui . The information for the connector is:

Display Name: GitHub
Docker repository name: airbyte/source-github
Docker image tag: 0.1.0
Documentation URL: hub.docker.com/r/airbyte/source-github

Please let us know if you have any further questions.

Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants