Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source MySQL: unsigned numeric values larger than signed integer size break connector #3840

Closed
sherifnada opened this issue Jun 3, 2021 · 0 comments · Fixed by #3846
Closed
Assignees
Labels

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Jun 3, 2021

Expected Behavior

I expect Airbyte syncs to succeed when replicating a MySQL table which contains an unsigned int column in which some of the values are larger than 2^32-1.

Slack thread: https://airbytehq.slack.com/archives/C01MFR03D5W/p1622696364083700

Current Behavior

The sync breaks as reported by a user. They sent the following logs:

2021-06-03 05:13:13 ERROR (/tmp/workspace/59/2) LineGobbler(voidCall):69 - Exception in thread "main" java.lang.RuntimeException: java.sql.SQLDataException: Value '4176160650' is outside of valid range for type java.lang.Integer

Suggestions for solution

If we can identify inside the connector if the column is unsigned then we should use Long for unsigned and Integer otherwise.

If we can't identify if the column is unsigned then we should always use long.

Logs

Steps to Reproduce

  1. Create a table in a mysql db with column unsigned int
  2. insert a row with value 3428724653
  3. run a sync from airbyte to any destination
  4. 💣

Severity of the bug for you

High -- preventing user from using Airbyte

Airbyte Version

Connector Version (if applicable)

Additional context

┆Issue is synchronized with this Asana task by Unito

@sherifnada sherifnada added type/bug Something isn't working area/connectors Connector related issues priority/high High priority labels Jun 3, 2021
@sherifnada sherifnada changed the title Source MySQL: handle unsigned numeric types Source MySQL: unsigned numeric values larger than signed integer size break connector Jun 3, 2021
@DoNotPanicUA DoNotPanicUA self-assigned this Jun 3, 2021
@DoNotPanicUA DoNotPanicUA linked a pull request Jun 3, 2021 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants