destination-mysql: convert prod code to kotlin #40553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
edgao
reviewed
Jun 26, 2024
| @@ -11,6 +11,7 @@ | |||
| import io.airbyte.cdk.integrations.base.spec_modification.SpecModifyingDestination; | |||
| import io.airbyte.commons.json.Jsons; | |||
| import io.airbyte.protocol.models.v0.ConnectorSpecification; | |||
| import io.airbyte.integrations.destination.mysql.MySQLDestination; | |||
There was a problem hiding this comment.
why are these new imports necessary?
| @@ -11,6 +11,6 @@ import org.testcontainers.utility.DockerImageName | |||
| /** Much like the destination-postgres PostgresTestDatabase, this was copied from source-mysql. */ | |||
| class MySQLContainerFactory : ContainerFactory<MySQLContainer<*>>() { | |||
| override fun createNewContainer(imageName: DockerImageName?): MySQLContainer<*> { | |||
| return MySQLContainer(imageName?.asCompatibleSubstituteFor("mysql")) | |||
| return MySQLContainer(imageName?.asCompatibleSubstituteFor("io/airbyte/integrations/destination/mysql")) | |||
There was a problem hiding this comment.
what is this? afaict mysql is meant to be a docker image name, not a java package name?
There was a problem hiding this comment.
some stupid refactoring coming from me moving files into the kotlin directory... Thank you for noticing it
stephane-airbyte
force-pushed
the
stephane/06-26-destination-mysql_convert_prod_code_to_kotlin
branch
from
c396f63
to
17caebf
Compare
octavia-squidington-iii
added
area/documentation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
stephane-airbyte
force-pushed
the
stephane/06-26-destination-mysql_convert_prod_code_to_kotlin
branch
2 times, most recently
from
8ba9753
to
5a961e1
Compare
2 tasks
stephane-airbyte
force-pushed
the
stephane/06-26-destination-mysql_convert_prod_code_to_kotlin
branch
from
5a961e1
to
4d53da7
Compare
edgao
approved these changes
Jun 26, 2024
stephane-airbyte
force-pushed
the
stephane/06-26-destination-mysql_convert_prod_code_to_kotlin
branch
from
4d53da7
to
c6f78e4
Compare
This was referenced Jun 26, 2024
Merge activity
|
stephane-airbyte
deleted the
stephane/06-26-destination-mysql_convert_prod_code_to_kotlin
branch
xiaohansong
pushed a commit
that referenced
this pull request
Jul 9, 2024
## What <!-- * Describe what the change is solving. Link all GitHub issues related to this change. --> ## How <!-- * Describe how code changes achieve the solution. --> ## Review guide <!-- 1. `x.py` 2. `y.py` --> ## User Impact <!-- * What is the end result perceived by the user? * If there are negative side effects, please list them. --> ## Can this PR be safely reverted and rolled back? <!-- * If unsure, leave it blank. --> - [ ] YES 💚 - [ ] NO ❌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?