Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination S3: Allow special chars for table_prefix #4654

Closed
m-ronchi opened this issue Jul 9, 2021 · 4 comments · Fixed by #11173
Closed

Destination S3: Allow special chars for table_prefix #4654

m-ronchi opened this issue Jul 9, 2021 · 4 comments · Fixed by #11173
Assignees
Labels

Comments

@m-ronchi
Copy link
Contributor

m-ronchi commented Jul 9, 2021

Hi,
I am trying to write to S3 destination with keys formatted as static_prefix/source=<namespace>/object=<table_name>/<filename>, like this:
screenshot

aitbyte is normalizing the path to only contain letters and unserscores, resulting in paths like this:
static_prefix/source_<namespace>/object_<table_name>/<filename>

configured paths should not be modified

@m-ronchi m-ronchi added the type/enhancement New feature or request label Jul 9, 2021
@marcosmarxm marcosmarxm changed the title Mangled path in S3 destinations Destination S3: Allow special chars for table_prefix Jul 10, 2021
@marcosmarxm
Copy link
Member

thanks @m-ronchi. I know the use of = when you partitioned your data using parquet format. https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-keys.html#object-key-guidelines probably is possible to do. @tuliren tagging you here see some opinion.

@marcosmarxm marcosmarxm added the area/connectors Connector related issues label Jul 10, 2021
@tuliren tuliren self-assigned this Jul 22, 2021
@sherifnada sherifnada added the priority/medium Medium priority label Oct 7, 2021
@misteryeo misteryeo added type/bug Something isn't working and removed type/enhancement New feature or request labels Feb 8, 2022
@etsybaev etsybaev self-assigned this Mar 9, 2022
@etsybaev
Copy link
Contributor

etsybaev commented Mar 14, 2022

Hi @m-ronchi .

Many thanks for your ticket.
Quick question: are you interested in "=" symbols only or in some other symbols as well?

AWS guide proposes to URL encode these symbols just in case. Would it be ok for your case?
https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-keys.html#object-key-guidelines

Many of those would make a URL to file invalid without URL encoding

Could you please confirm that an example on capture below is what you're requesting for?
Selection_037

Thanks

@m-ronchi
Copy link
Contributor Author

Hi,
basically, I wanted to be able to configure an AWS Glue crawler to create a partitioned spectrum schema.

other than the = character (mandatory to be able to partition), I may need the other characters, e.g. .../date=2022-03-15/...

I haven't tested url encoding

yes, the screenshot is what I have on my spectrum sources

@etsybaev
Copy link
Contributor

#11173

@etsybaev etsybaev linked a pull request Mar 17, 2022 that will close this issue
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants