Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Ads source connector: Need a "login-customer-id" setting #5150

Closed
zestyping opened this issue Aug 3, 2021 · 1 comment · Fixed by #5159
Closed

Google Ads source connector: Need a "login-customer-id" setting #5150

zestyping opened this issue Aug 3, 2021 · 1 comment · Fixed by #5159

Comments

@zestyping
Copy link
Contributor

Enviroment

  • Airbyte version: 0.28.1-alpha
  • OS Version / Instance: AWS EC2
  • Deployment: Docker
  • Source Connector and version: Google Ads 0.1.4
  • Destination Connector and version: BigQuery (unstructured) 0.3.10
  • Severity: High
  • Step where error happened: Sync job / Setup new connection

Current Behavior

When I attempt to run a sync with the new Google Ads source connector, I get this error message in the sync log:

2021-08-02 23:04:58 ERROR () LineGobbler(voidCall):85 -   message: "User doesn\'t have permission to access customer. Note: If you\'re accessing a client customer, the manager\'s customer id must be set in the \'login-customer-id\' header. See https://developers.google.com/google-ads/api/docs/concepts/call-structure#cid"

It looks like I need to provide the manager's customer ID, but this setting is not available on the source settings screen (and I assume that sending the login-customer-id header is not supported).

Expected Behavior

The source settings screen should provide a place to enter the manager's customer ID, and if entered, it should be sent along with the request as the login-customer-id as described in the Google API documentation.

Logs

logs-63-2.txt

Steps to Reproduce

  1. Set up a Google Ads source, specifying the customer ID for a customer that is managed under a Manager Account.
  2. Set up any destination.
  3. Run a sync from the Google Ads source to the destination.

Are you willing to submit a PR?

If someone could point me at the right place to get started, I'd be willing to give this a try!

@zestyping zestyping added the type/bug Something isn't working label Aug 3, 2021
@marcosmarxm marcosmarxm added the area/connectors Connector related issues label Aug 3, 2021
@sherifnada sherifnada added the priority/high High priority label Aug 3, 2021
@sherifnada sherifnada added this to the Connectors August 6th milestone Aug 3, 2021
@yevhenii-ldv yevhenii-ldv self-assigned this Aug 3, 2021
@potatozerg
Copy link

@zestyping Hi, I'm also working on Google Ads. How did you get the refresh token? Is this the one you followed? https://developers.google.com/identity/protocols/oauth2/web-server#obtainingaccesstokens
I'm having trouble defining the scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment