Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAT: TestIncremental.test_two_sequential_reads failed for equal data in array #5735

Closed
annalvova05 opened this issue Aug 30, 2021 · 0 comments · Fixed by #5738
Closed

SAT: TestIncremental.test_two_sequential_reads failed for equal data in array #5735

annalvova05 opened this issue Aug 30, 2021 · 0 comments · Fixed by #5738
Assignees
Labels
Acceptance Tests https://docs.google.com/document/d/1pFLR8eLP5VOj6vDtWe69KZL0aWWHEA6Vkbod6NYJon4/edit# area/connectors Connector related issues connectors/source/close-com connectors/sources-api type/bug Something isn't working

Comments

@annalvova05
Copy link
Contributor

While testing the new Close.com connector, an error was found in the test_two_sequential_reads acceptance test.

There are two equal Records with not sorted data in the "permissions" field

{
    'date_created': '0001-01-01T00:00:00',
    'date_updated': '0001-01-01T00:00:00',
    'editable': False,
    'id': 'superuser',
    'name': 'Super User',
    'organization_id': 'orga_ya3w9oMjeLtWe7zFGZr63Dz8ruBbjybG0EIUdUXaESi',
    'permissions': [
      'merge_leads',
      'delete_leads',
      'manage_others_activities',
      'delete_own_activities',
      'call_coach_listen',
      'manage_others_opportunities',
      'manage_customizations',
      'bulk_sequence_subscriptions',
      'delete_own_tasks',
      'bulk_import',
      'manage_group_numbers',
      'bulk_edit',
      'bulk_email',
      'manage_team_smart_views',
      'delete_own_opportunities',
      'call_coach_barge',
      'manage_team_email_templates',
      'manage_email_sequences',
      'calling',
      'export',
      'bulk_delete',
      'manage_others_tasks'
    ]
  } 

and

{
    'date_created': '0001-01-01T00:00:00',
    'date_updated': '0001-01-01T00:00:00',
    'editable': False,
    'id': 'superuser',
    'name': 'Super User',
    'organization_id': 'orga_ya3w9oMjeLtWe7zFGZr63Dz8ruBbjybG0EIUdUXaESi',
    'permissions': [
      'call_coach_listen',
      'bulk_import',
      'merge_leads',
      'manage_others_opportunities',
      'delete_leads',
      'delete_own_activities',
      'bulk_edit',
      'bulk_delete',
      'call_coach_barge',
      'export',
      'bulk_sequence_subscriptions',
      'manage_team_email_templates',
      'calling',
      'bulk_email',
      'manage_others_activities',
      'manage_email_sequences',
      'manage_group_numbers',
      'delete_own_tasks',
      'manage_customizations',
      'manage_others_tasks',
      'delete_own_opportunities',
      'manage_team_smart_views'
    ]
  }

Test failed due to incorrect hash comparison in airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/utils/compare.py.

Solution: add one more magic method __eq__ and wrap DictWithHash class to @functools.total_ordering decorator.

@annalvova05 annalvova05 added the type/bug Something isn't working label Aug 30, 2021
@annalvova05 annalvova05 self-assigned this Aug 30, 2021
@annalvova05 annalvova05 linked a pull request Aug 30, 2021 that will close this issue
36 tasks
@sherifnada sherifnada added Acceptance Tests https://docs.google.com/document/d/1pFLR8eLP5VOj6vDtWe69KZL0aWWHEA6Vkbod6NYJon4/edit# area/connectors Connector related issues labels Aug 31, 2021
@annalvova05 annalvova05 changed the title TestIncremental.test_two_sequential_reads failed for equal data in array SAT: TestIncremental.test_two_sequential_reads failed for equal data in array Aug 31, 2021
@avida avida mentioned this issue Oct 29, 2021
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acceptance Tests https://docs.google.com/document/d/1pFLR8eLP5VOj6vDtWe69KZL0aWWHEA6Vkbod6NYJon4/edit# area/connectors Connector related issues connectors/source/close-com connectors/sources-api type/bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants