Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source facebook marketing: add end_date configuration #6046

Closed
darian-heede opened this issue Sep 14, 2021 · 0 comments · Fixed by #6054
Closed

Source facebook marketing: add end_date configuration #6046

darian-heede opened this issue Sep 14, 2021 · 0 comments · Fixed by #6054

Comments

@darian-heede
Copy link
Contributor

darian-heede commented Sep 14, 2021

Tell us about the problem you're trying to solve

I would like to be able to add an end_date configuration to the source-facebook-marketing connector. Right now, the connector defaults to fetching all data starting from the configured start_date up to the current date (now). Most of the times, I only fetch data for a predefined date range. I also often have the use case that details like a campaign_name or ad_name have changed for historical data and would like to only fetch the changes for the affected dates.

Describe the solution you’d like

I would like the source configuration to allow for the specification of an end_date. This specification can be optional, defaulting to the current setup. This way, no one using the connector is forced to make changes.

Are you willing to submit a PR?

Yes, I can have the PR ready quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants