Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK: Add tests for the HTttpStream to check authenticator call on each request #6084

Open
htrueman opened this issue Sep 15, 2021 · 0 comments
Labels
area/connectors Connector related issues autoteam frozen Not being actively worked on team/extensibility type/enhancement New feature or request

Comments

@htrueman
Copy link
Contributor

Tell us about the problem you're trying to solve

We need to test that HTttpStream correctly calls the authenticator on every request.

Describe the solution you’d like

Add new tests to test_http.py which will call the request and check if the authenticator was called correctly. As result the authenticator should modify the request (e.g. update request headers).

Describe the alternative you’ve considered or used

None

Additional context

This issue continues the #5731 PR, where we added the requests native auth support.

Are you willing to submit a PR?

Yes, I am.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues autoteam frozen Not being actively worked on team/extensibility type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants