Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAT: correct the record validation check according to the scheme (as an option: add validation that type is not null) #6132

Closed
yevhenii-ldv opened this issue Sep 16, 2021 · 0 comments · Fixed by #6501
Assignees
Labels
Acceptance Tests https://docs.google.com/document/d/1pFLR8eLP5VOj6vDtWe69KZL0aWWHEA6Vkbod6NYJon4/edit# area/connectors Connector related issues type/bug Something isn't working

Comments

@yevhenii-ldv
Copy link
Contributor

Tell us about the problem you're trying to solve

Currently, there is a problem that if the stream scheme does not coincide at all with the response, then the validation in SAT tests is successful.

For example, there was a case with the Squaré connector, when initially the scheme was indicated incorrectly and was indicated for the general response from the API, and not for a single record, however, the SAT tests did not catch this moment and did not indicate an error.

An example of the schema here.

Describe the solution you’d like

SAT catches such cases at the moment of testing, and not the reviewer sees it at the moment of code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acceptance Tests https://docs.google.com/document/d/1pFLR8eLP5VOj6vDtWe69KZL0aWWHEA6Vkbod6NYJon4/edit# area/connectors Connector related issues type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants