Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source facebook-marketing: fix test failures #6170

Closed
Tracked by #5978
sherifnada opened this issue Sep 17, 2021 · 2 comments · Fixed by #6499
Closed
Tracked by #5978

source facebook-marketing: fix test failures #6170

sherifnada opened this issue Sep 17, 2021 · 2 comments · Fixed by #6499
Assignees
@avida
Labels
connectors/source/facebook-marketing connectors/sources-api
Milestone
Connectors, Octob...

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Sep 17, 2021 •
edited

the connector's build is failing. This issue tracks fixing it.
@sherifnada sherifnada mentioned this issue Sep 17, 2021
Closed
10 tasks
@vitaliizazmic vitaliizazmic self-assigned this Sep 20, 2021
@Zirochkaa
Copy link
Contributor

Looks like it's an issue with new transform function:

image

Need to gebug this function and find out why it's failing (on which record, for example).

@Zirochkaa Zirochkaa assigned avida and unassigned vitaliizazmic Sep 20, 2021
@vitaliizazmic
Copy link
Contributor

There are two types of error in logs. First error connected to test failing while merging solution for #5190 TestFullRefresh fails because records from two different syncing aren't identical. Another error is caused by recent changes in source. TestBasicRead fails for AdsInsights streams. It finish with KeyError: 'type' in convert_to_schema_types.

@avida avida mentioned this issue Sep 28, 2021
Merged
38 tasks
@Zirochkaa Zirochkaa mentioned this issue Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avida avida

Labels
connectors/source/facebook-marketing connectors/sources-api
Projects
None yet
Milestone
Connectors, October 1st 2021
Development

Successfully merging a pull request may close this issue.

🐛 Facebook marketing source: fix field value type conversion airbytehq/airbyte
5 participants
@avida @sherifnada @karinakuz @Zirochkaa @vitaliizazmic